anmolanmol1234 commented on code in PR #8056:
URL: https://github.com/apache/hadoop/pull/8056#discussion_r2584563119
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/ReadBufferManagerV2.java:
##########
@@ -105,14 +109,33 @@ public final class ReadBufferManagerV2 extends
ReadBufferManager {
private static AtomicBoolean isConfigured = new AtomicBoolean(false);
+ /* Metrics collector for monitoring the performance of the ABFS read thread
pool. */
+ private final AbfsReadResourceUtilizationMetrics readThreadPoolMetrics;
+ /* The ABFSCounters instance for updating read buffer manager related
metrics. */
+ private final AbfsCounters abfsCounters;
+ /* Tracks the last scale direction applied, or empty if none. */
+ private volatile String lastScaleDirection = EMPTY_STRING;
+ /* Maximum CPU utilization observed during the monitoring interval. */
+ private volatile double maxJvmCpuUtilization = 0.0;
+
/**
* Private constructor to prevent instantiation as this needs to be
singleton.
+ *
+ * @param abfsCounters the {@link AbfsCounters} used for managing read
operations.
*/
- private ReadBufferManagerV2() {
+ private ReadBufferManagerV2(AbfsCounters abfsCounters) {
Review Comment:
So, we just need a placeholder for the metrics initialization, these metrics
are filesystem agnostic, they only tell the current resource utilization and
what matters is the JVM. We can discuss this more offline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
