[
https://issues.apache.org/jira/browse/HADOOP-17295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18043717#comment-18043717
]
ASF GitHub Bot commented on HADOOP-17295:
-----------------------------------------
github-actions[bot] commented on PR #2358:
URL: https://github.com/apache/hadoop/pull/2358#issuecomment-3629625363
We're closing this stale PR because it has been open for 100 days with no
activity. This isn't a judgement on the merit of the PR in any way. It's just a
way of keeping the PR queue manageable.
If you feel like this was a mistake, or you would like to continue working
on it, please feel free to re-open it and ask for a committer to remove the
stale tag and review again.
Thanks all for your contribution.
> Move dedicated pre-logging statements into existing logging guards
> ------------------------------------------------------------------
>
> Key: HADOOP-17295
> URL: https://issues.apache.org/jira/browse/HADOOP-17295
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Chen Zhi
> Assignee: Chen Zhi
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> I find some cases where some pre-processing statements dedicated to logging
> calls are not guarded by existing logging guards. Most of them are easy to
> fix. And the performance and maintainability of these logging calls can be
> improved to some extend. So I create a PR to fix them.
> These issues are detected by a static analysis tool wrote by myself. This
> tool can extract all the dedicated statements for each debug-logging calls
> (i.e., the results of these statements are only used by debug-logging calls).
> Because I realize that debug logs will incur overhead in production, such as
> string concatenation and method calls in the parameters of logging calls as
> well as pre-processing statements. And I want to perform a systematic
> evaluation for the overhead of debugging logging calls in production.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
