ryukobayashi opened a new pull request, #8127:
URL: https://github.com/apache/hadoop/pull/8127
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
Fix queue starvation in FairSharePolicy when queues have pending
applications
Problem
FairSharePolicy causes queue starvation when a queue has pending
applications waiting for AM allocation but no running containers yet (demand=0,
getNumRunnableApps()>0). The queue receives no allocations despite having
pending applications and
configured minShare guarantees.
Root Cause
compareDemand() treats all queues with demand=0 as empty and assigns
lowest priority, blocking progression to minShare comparison stage.
Solution
Modified compareDemand() to distinguish truly empty queues
(getNumRunnableApps()==0) from queues with pending applications
(getNumRunnableApps()>0). Queues with pending applications now progress to
minShare comparison, preventing starvation.
Testing
Added TestFairSharePolicyPendingApps with 4 test cases covering pending
app scenarios and minShare comparison.
### How was this patch tested?
Add the unit test.
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
