[
https://issues.apache.org/jira/browse/HADOOP-19472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18047232#comment-18047232
]
ASF GitHub Bot commented on HADOOP-19472:
-----------------------------------------
anujmodi2021 commented on code in PR #8141:
URL: https://github.com/apache/hadoop/pull/8141#discussion_r2642468945
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/FileSystemConfigurations.java:
##########
Review Comment:
I know this is not a part of change here but since we are doing code cleanup
here, I feel we should keep these constants in some constant file only like
`InternalConstants` or `MetricsConstants`.
This file mainly contains constants used in configuration.
Starting from `ZERO` to `SCALE_DIRECTION_NO_ACTION_NEEDED`
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/FileSystemConfigurations.java:
##########
@@ -42,19 +42,6 @@ public final class FileSystemConfigurations {
* Number of bytes in a gigabyte.
*/
public static final long BYTES_PER_GIGABYTE = 1024L * 1024 * 1024;
- /**
Review Comment:
There are a few constants in AbfsHttpConstants file that also need to be
removed.
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/enums/AbfsWriteResourceUtilizationMetricsEnum.java:
##########
@@ -1,107 +0,0 @@
-/**
Review Comment:
Sine there is only one resource utilization metric left. Do we need the base
class?
Can we simply have one stand alone class called `ResourceUtilizationMetrics`
instead of saying read/write?
Also anyway we are monitoring JVM resources here, so single metric is
sufficient IMO.
> ABFS: Enhance performance of ABFS driver for write-heavy workloads
> ------------------------------------------------------------------
>
> Key: HADOOP-19472
> URL: https://issues.apache.org/jira/browse/HADOOP-19472
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.4.1
> Reporter: Anmol Asrani
> Assignee: Anmol Asrani
> Priority: Minor
> Labels: pull-request-available
> Fix For: 3.4.1
>
>
> The goal of this work item is to enhance the performance of ABFS Driver for
> write-heavy workloads by improving concurrency within writes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
