[
https://issues.apache.org/jira/browse/HADOOP-19756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18048306#comment-18048306
]
Chris Nauroth commented on HADOOP-19756:
----------------------------------------
Hello [~appodictic]. I think the diff looks pretty good. Would you mind sending
a pull request to github.com/apache/hadoop (trunk branch), and we'll complete
the review there? Thank you.
> exception.c compile macro fights the future
> -------------------------------------------
>
> Key: HADOOP-19756
> URL: https://issues.apache.org/jira/browse/HADOOP-19756
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.4.2
> Reporter: Edward Capriolo
> Priority: Major
> Attachments: a.diff
>
>
> The macro in exception.c is backwards
> {code:java}
> // MT-Safe under Solaris or glibc >= 2.32 not supporting sys_errlist/sys_nerr
> #if defined(__sun)
> #define USE_STR_ERROR
> #elif defined(__GLIBC_PREREQ)
> #if __GLIBC_PREREQ(2, 32)
> #define USE_STR_ERROR
> #endif
> #endif {code}
> If penalizes those implementing the standard like alpine musc. If the logic
> is reversed platforms meeting the standard work out of the box.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
