eubnara commented on code in PR #8159:
URL: https://github.com/apache/hadoop/pull/8159#discussion_r2657073710
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java:
##########
@@ -2363,8 +2375,15 @@ protected String reconfigurePropertyImpl(String
property, String newVal)
DFS_NAMENODE_REPLICATION_WORK_MULTIPLIER_PER_ITERATION)
||
property.equals(DFS_NAMENODE_RECONSTRUCTION_PENDING_TIMEOUT_SEC_KEY)) {
return reconfReplicationParameters(newVal, property);
- } else if (property.equals(DFS_BLOCK_REPLICATOR_CLASSNAME_KEY) || property
- .equals(DFS_BLOCK_PLACEMENT_EC_CLASSNAME_KEY)) {
+ } else if (property.equals(DFS_BLOCK_REPLICATOR_CLASSNAME_KEY)
+ || property.equals(DFS_BLOCK_PLACEMENT_EC_CLASSNAME_KEY)
+ || property.equals(DFS_BLOCK_REPLICATOR_CROSS_DC_ASYNC_ENABLED_KEY)
+ ||
property.equals(DFS_BLOCK_REPLICATOR_CROSS_DC_PREFERRED_DATACENTER_KEY)
+ ||
property.equals(DFS_BLOCK_REPLICATOR_CROSS_DC_BANDWIDTH_LIMIT_MB_KEY)
+ ||
property.equals(DFS_BLOCK_REPLICATOR_CROSS_DC_BANDWIDTH_REFILL_PERIOD_SEC_KEY)
+ || property.equals(DFS_BLOCK_REPLICATOR_CROSS_DC_SYNC_PATHS_KEY)
+ ||
property.equals(DFS_BLOCK_REPLICATOR_CROSS_DC_LIMITED_SYNC_PATHS_KEY)
Review Comment:
In order to change configurations without restarting NameNode, I added
`BlockPlacementStatusWithCrossDC` related configurations here.
However, if you change multiple configurations simultaneously and
reconfigure it, `reconfBlockPlacementPolicy()` called multiple times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
