cnauroth commented on code in PR #8164: URL: https://github.com/apache/hadoop/pull/8164#discussion_r2662394891
########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/test/java/org/apache/hadoop/yarn/server/timelineservice/storage/FileSystemTimelineWriterImpl.java: ########## @@ -51,7 +52,27 @@ * This implements a FileSystem based backend for storing application timeline * information. This implementation may not provide a complete implementation of * all the necessary features. This implementation is provided solely for basic - * testing purposes, and should not be used in a non-test situation. + * testing purposes, and MUST NOT be used in a non-test situation. + * <p> + * Key limitations are: + * <ol> + * <li>Inadequate scalability and concurrency for production use</li> + * <li>Weak security: any authenticated caller can add events to any application + * timeline.</li> + * </ol> + * <p> + * To implement an atomic append it reads all the data in the original file, + * writes that to a temporary file, appends the new + * data there and renames that temporary file to the original path. + * This is makes the update operation slower and slower the longer an application runs. Review Comment: Nitpick: remove the word "is." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
