pan3793 commented on code in PR #8167: URL: https://github.com/apache/hadoop/pull/8167#discussion_r2664058315
########## BUILDING.txt: ########## @@ -480,7 +480,7 @@ Installing required dependencies for clean install of macOS 10.14: $ /usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)" * Install OpenJDK 8 $ brew tap AdoptOpenJDK/openjdk - $ brew cask install adoptopenjdk8 + $ brew cask install temurin17 Review Comment: recent version of macOS removes the built-in script languages, so it should use a different command that does not rely on OS Ruby to install homebrew ```patch - * Install OpenJDK 8 + * Install OpenJDK 17 ``` brew main repo has `openjdk@17` so no need for `brew tap AdoptOpenJDK/openjdk` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
