[
https://issues.apache.org/jira/browse/HADOOP-19767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18050586#comment-18050586
]
ASF GitHub Bot commented on HADOOP-19767:
-----------------------------------------
anmolanmol1234 commented on code in PR #8153:
URL: https://github.com/apache/hadoop/pull/8153#discussion_r2671824431
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStream.java:
##########
@@ -888,48 +953,131 @@ public String toString() {
return sb.toString();
}
+ /**
+ * Getter for bCursor.
+ * @return the bCursor
+ */
@VisibleForTesting
int getBCursor() {
return this.bCursor;
}
+ /**
+ * Setter for bCursor.
+ * @param bCursor the bCursor to set
+ */
+ protected void setBCursor(int bCursor) {
+ this.bCursor = bCursor;
+ }
+
+ /**
+ * Getter for fCursor.
+ * @return the fCursor
+ */
@VisibleForTesting
long getFCursor() {
return this.fCursor;
}
+ /**
+ * Setter for fCursor.
+ * @param fCursor the fCursor to set
+ */
+ protected void setFCursor(long fCursor) {
+ this.fCursor = fCursor;
+ }
+
+ /**
+ * Getter for fCursorAfterLastRead.
+ * @return the fCursorAfterLastRead
+ */
@VisibleForTesting
long getFCursorAfterLastRead() {
return this.fCursorAfterLastRead;
}
+ /**
+ * Setter for fCursorAfterLastRead.
+ * @param fCursorAfterLastRead the fCursorAfterLastRead to set
+ */
+ protected void setFCursorAfterLastRead(long fCursorAfterLastRead) {
+ this.fCursorAfterLastRead = fCursorAfterLastRead;
+ }
+
+ /**
+ * Getter for limit.
+ * @return the limit
+ */
@VisibleForTesting
- long getLimit() {
+ int getLimit() {
Review Comment:
why changed from long to int ?
> ABFS: [Read] Introduce Abfs Input Policy for detecting read patterns
> --------------------------------------------------------------------
>
> Key: HADOOP-19767
> URL: https://issues.apache.org/jira/browse/HADOOP-19767
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.4.2
> Reporter: Anuj Modi
> Assignee: Anuj Modi
> Priority: Major
> Labels: pull-request-available
>
> Since the onset of ABFS Driver, there has been a single implementation of
> AbfsInputStream. Different kinds of workloads require different heuristics to
> give the best performance for that type of workload. For example:
> # Sequential Read Workloads like DFSIO and DistCP gain performance
> improvement from prefetched
> # Random Read Workloads on other hand do not need Prefetches and enabling
> prefetches for them is an overhead and TPS heavy
> # Query Workloads involving Parquet/ORC files benefit from improvements like
> Footer Read and Small Files Reads
> To accomodate this we need to determine the pattern and accordingly create
> Input Streams implemented for that particular pattern.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
