[
https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401584#comment-13401584
]
Robert Joseph Evans commented on HADOOP-8523:
---------------------------------------------
A couple of comments
# In smart-apply patch we are already figuring out the PLEVEL and by the time
it gets to the dryrun check we know that it will already apply with either a p0
p1 or p2 otherwise it would have exited by this point. We really don't need to
try and apply the patch yet again.
# Instead of trying to add yet another thing to setup, with a cleanupAndExit in
the middle of it. I would prefer to see setup split up into three different
functions. One to download the patch, one to test to see if the patch applies,
and one to do the initial build.
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.23.3, 2.0.1-alpha
> Reporter: Jack Dintruff
> Priority: Minor
> Labels: newbie
> Attachments: HADOOP-8523.patch, Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or
> one that doesn't compile, the script spends a lot of time building Hadoop
> before checking to see if the patch is invalid. It would help devs if it
> checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
