cnauroth commented on code in PR #8182: URL: https://github.com/apache/hadoop/pull/8182#discussion_r2733226547
########## pom.xml: ########## @@ -701,16 +701,28 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/x <version>${project.version}</version> </docletArtifact> </docletArtifacts> - <useStandardDocletOptions>true</useStandardDocletOptions> - + <additionalJOptions> + <additionalJOption>-J--add-exports=jdk.javadoc/jdk.javadoc.internal.tool=ALL-UNNAMED</additionalJOption> + </additionalJOptions> + <additionalOptions> Review Comment: Is this necessary in `additionalOptions`, which is options passed to `javadoc`? Since `--add-exports` is a JVM argument, I would have expected we only need it in `additionalJOptions`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
