[ 
https://issues.apache.org/jira/browse/HADOOP-19811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18057791#comment-18057791
 ] 

ASF GitHub Bot commented on HADOOP-19811:
-----------------------------------------

pan3793 commented on code in PR #8243:
URL: https://github.com/apache/hadoop/pull/8243#discussion_r2792250218


##########
hadoop-cloud-storage-project/hadoop-gcp/pom.xml:
##########
@@ -336,9 +346,14 @@
                       <includes>
                         <include>io.grpc.**</include>
                         <include>io.opencensus.**</include>
+                        <include>io.opentelemetry.**</include>
                         <include>io.perfmark.**</include>
                       </includes>
                     </relocation>
+                    <relocation>
+                      <pattern>META-INF/versions/9/io/opentelemetry</pattern>

Review Comment:
   it was removed in 
https://github.com/open-telemetry/opentelemetry-java/pull/7221





> hadoop-gcp does not relocate shaded OpenTelemetry dependencies
> --------------------------------------------------------------
>
>                 Key: HADOOP-19811
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19811
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs/gcs
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>            Priority: Blocker
>              Labels: pull-request-available
>
> The hadoop-gcp sub-module intends to produce a jar with a completely shaded 
> and relocated set of internal dependencies. Currently, the OpenTelemetry 
> classes are not relocated, which creates a risk of version conflicts with 
> downstream projects. Thank you to [~chengpan] for reporting this.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to