hfutatzhanghb commented on PR #6530: URL: https://github.com/apache/hadoop/pull/6530#issuecomment-3895752249
> Agree with @ZanderXu . I think we should try not to modify namenode or protocol. Actually, there is a trick that key update command can only appear in the last two position of the `cmds` according to `DatanodeManager#handleHeartbeat`, so we do not need to iterate all commands on datanode. @Hexiaoqiao Thanks for your reviewing. Actully, i have implemented inside namenode in the first version. I will post it laterly. BTW, from my observation, the loop has a little impact on the performance of DataNode when there are large number commands(we met 10K+ and there is no side-effect). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
