[
https://issues.apache.org/jira/browse/HADOOP-18898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18058844#comment-18058844
]
ASF GitHub Bot commented on HADOOP-18898:
-----------------------------------------
eciuca opened a new pull request, #8253:
URL: https://github.com/apache/hadoop/pull/8253
### Description of PR
Child JVMs spawned by Maven's failsafe plugin during integration tests do
not receive the `--add-opens` JVM options needed for Java 17+ compatibility.
**Two fixes:**
1. **`hadoop-project/pom.xml`** — Added
`<argLine>${maven-surefire-plugin.argLine}</argLine>` to the
`maven-failsafe-plugin` configuration in `<pluginManagement>`. This ensures all
failsafe usages across the project (hadoop-aws, hadoop-azure, hadoop-gcp,
hadoop-client-integration-tests) inherit the `--add-opens` options by default,
matching the existing surefire configuration.
2. **`hadoop-cloud-storage-project/hadoop-tos/pom.xml`** — Fixed a bug where
two `<argLine>` elements existed in the same surefire `<configuration>` block.
Since `argLine` is a scalar `String` parameter, the second element
(`-Xmx2048m`) silently overwrote the first one that included
`${maven-surefire-plugin.argLine}`, causing all JPMS options to be lost in 8
forked test JVMs. Merged into a single
`<argLine>${maven-surefire-plugin.argLine} -Xmx2048m</argLine>`.
### How was this patch tested?
- Verified that `maven-failsafe-plugin` in `hadoop-project/pom.xml`
previously had no `argLine` configuration (only version was set in
`<pluginManagement>`)
- Confirmed that the parallel-tests profiles in hadoop-aws, hadoop-azure,
hadoop-gcp already set `argLine` explicitly with
`${maven-surefire-plugin.argLine}`, but the sequential-tests profiles and
hadoop-client-integration-tests did not
- Confirmed that Maven's XML-to-Java mapping for scalar `String` parameters
uses last-element-wins semantics for duplicate elements
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
### AI Tooling
- [x] The PR includes the phrase "Contains content generated by Claude Code"
- [x] My use of AI contributions follows the ASF legal policy
https://www.apache.org/legal/generative-tooling.html
> Add argLine configuration to maven-surefire-plugin
> --------------------------------------------------
>
> Key: HADOOP-18898
> URL: https://issues.apache.org/jira/browse/HADOOP-18898
> Project: Hadoop Common
> Issue Type: Task
> Components: build
> Reporter: Bruno Ramirez
> Priority: Major
>
> Child jvms spawned by the maven do not have add-opens command line options.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
