eciuca commented on PR #8253: URL: https://github.com/apache/hadoop/pull/8253#issuecomment-3912407882
Thanks for the review, @hadoop-yetus. **Re: trunk failures (mvninstall, compile, mvnsite, javadoc):** These all fail on trunk due to the broken `io.github.ascopes:protobuf-maven-plugin` configuration in `hadoop-yarn-csi`. Our patch fixes this — all "Patch Compile Tests" pass (mvninstall ✅, compile ✅, mvnsite ✅, unit ✅, shadedclient ✅). **Re: javadoc warnings (26 new):** These are **pre-existing** missing-comment warnings in `hadoop-yarn-csi` source files (e.g. `CsiClient.java`, `CsiGrpcClient.java`, `ProtoTranslator.java`). They appear as "new" only because trunk cannot build `hadoop-yarn-csi` at all (protobuf failure → 0 baseline warnings). Once our patch fixes the build, javadoc can run and surfaces these pre-existing issues. None of these warnings are in files touched by this PR. **Re: test4tests:** This PR only modifies Maven `pom.xml` build configuration (argLine propagation and protobuf plugin parameters). No new tests are needed — the fix is verified by the successful compilation and unit test execution in the patch phase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
