edwardcapriolo commented on code in PR #8359:
URL: https://github.com/apache/hadoop/pull/8359#discussion_r2965281919
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAddBlockRetry.java:
##########
@@ -122,7 +123,7 @@ public void testRetryAddBlockWhileInChooseTarget() throws
Exception {
LocatedBlock newBlock;
try {
newBlock = FSDirWriteFileOp.storeAllocatedBlock(ns, src,
- HdfsConstants.GRANDFATHER_INODE_ID, "clientName", null, targets);
+ HdfsConstants.GRANDFATHER_INODE_ID, "clientName", null, targets, new
AtomicReference<>());
Review Comment:
The test should use like a mockito-spy or verify to show that the logging
happens as as side effect, and possibly when it doesn't happen, (eror etc)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
