cnauroth commented on code in PR #8350:
URL: https://github.com/apache/hadoop/pull/8350#discussion_r2976411837


##########
hadoop-common-project/hadoop-common/src/main/proto2-generated/org/apache/hadoop/ipc/protobuf/ProtobufRpcEngineProtos.java:
##########
@@ -1,56 +1,39 @@
-/**

Review Comment:
   The prior version of all 3 Java files contained the license header. I think 
we need to maintain this, because the files will be checked in and included in 
release source distributions. (We would need to remove the exclusions from 
apache-rat-plugin too.)
   
   I don't think the license header matters for code generated at build time 
like 
hadoop-hdfs-project/hadoop-hdfs-client/target/generated-sources/java/org/apache/hadoop/hdfs/protocol/proto/ClientNamenodeProtocolProtos.java.
 I think it matters here though because these files make there way into the 
source distribution.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to