[
https://issues.apache.org/jira/browse/HADOOP-19843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18067769#comment-18067769
]
ASF GitHub Bot commented on HADOOP-19843:
-----------------------------------------
cnauroth commented on code in PR #8350:
URL: https://github.com/apache/hadoop/pull/8350#discussion_r2976411837
##########
hadoop-common-project/hadoop-common/src/main/proto2-generated/org/apache/hadoop/ipc/protobuf/ProtobufRpcEngineProtos.java:
##########
@@ -1,56 +1,39 @@
-/**
Review Comment:
The prior version of all 3 Java files contained the license header. I think
we need to maintain this, because the files will be checked in and included in
release source distributions. (We would need to remove the exclusions from
apache-rat-plugin too.)
I don't think the license header matters for code generated at build time
like
hadoop-hdfs-project/hadoop-hdfs-client/target/generated-sources/java/org/apache/hadoop/hdfs/protocol/proto/ClientNamenodeProtocolProtos.java.
I think it matters here though because these files make there way into the
source distribution.
> Regenerate tracked proto2 source code for non-x86_64 platforms
> --------------------------------------------------------------
>
> Key: HADOOP-19843
> URL: https://issues.apache.org/jira/browse/HADOOP-19843
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.4.3
> Reporter: Cheng Pan
> Priority: Major
> Labels: pull-request-available
>
> https://lists.apache.org/thread/4sn3bb2qo9vz2kqgblhx3wdc35fkc3bd
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
