JHSUYU commented on PR #8364:
URL: https://github.com/apache/hadoop/pull/8364#issuecomment-4115007270

   > The fix makes sense. However, the test passes even if I comment out the 
fix.
   > 
   > Also, we have this bad bad of always write system test instead of unit 
tests. That is a bigger problem though not expected to fix in this PR.
   
   Thanks @jojochuang for the review! I'll update the test to make sure it 
actually fails without the fix. Later I will fix the remaining issues mentioned 
in HDFS-16136, it would be great if you could help review them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to