roryqi commented on PR #8347: URL: https://github.com/apache/hadoop/pull/8347#issuecomment-4153133514
It would better have tests before merging this into the branch. I know it's difficult to add integration tests. I will suggest that you could record a video. Notice that you should show the `md5` of the shaded jar. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
