[ 
https://issues.apache.org/jira/browse/HADOOP-19786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18070648#comment-18070648
 ] 

ASF GitHub Bot commented on HADOOP-19786:
-----------------------------------------

adoroszlai commented on code in PR #8186:
URL: https://github.com/apache/hadoop/pull/8186#discussion_r3029088837


##########
pom.xml:
##########
@@ -525,7 +525,11 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
https://maven.apache.org/x
         <plugin>
           <groupId>org.owasp</groupId>
           <artifactId>dependency-check-maven</artifactId>
-          <version>${dependency-check-maven.version}</version>
+          <version>${owasp-maven-plugin.version}</version>
+          <configuration>
+            <assemblyAnalyzerEnabled>false</assemblyAnalyzerEnabled>
+            <ossindexAnalyzerEnabled>false</ossindexAnalyzerEnabled>
+          </configuration>

Review Comment:
   Can you please explain
   - why these are being disabled,
   - whether this change is necessary for the fix,
   - what about dozens of other analyzers?
   
   `assemblyAnalyzerEnabled` is related to .NET.  The plugin's doc says:
   
   > specific analyzers will automatically disable themselves if no file types 
that they support are detected
   
   so it seems to be unnecessary to explicitly set it.





> owasp plugin does not run
> -------------------------
>
>                 Key: HADOOP-19786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19786
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Edward Capriolo
>            Assignee: Edward Capriolo
>            Priority: Major
>              Labels: pull-request-available
>
> The owasp plugin doesn't specify a version and it does not run.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to