CapMoon commented on code in PR #8360:
URL: https://github.com/apache/hadoop/pull/8360#discussion_r3031171649
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:
##########
@@ -3111,14 +3112,20 @@ LocatedBlock getAdditionalBlock(
checkOperation(OperationCategory.WRITE);
writeLock(RwLockMode.GLOBAL);
LocatedBlock lb;
+ BlockInfo blockInfo;
try {
checkOperation(OperationCategory.WRITE);
- lb = FSDirWriteFileOp.storeAllocatedBlock(
+ Pair<LocatedBlock, BlockInfo> pair =
FSDirWriteFileOp.storeAllocatedBlock(
this, src, fileId, clientName, previous, targets);
+ lb = pair.getLeft();
+ blockInfo = pair.getRight();
} finally {
writeUnlock(RwLockMode.GLOBAL, operationName);
}
getEditLog().logSync();
+ if (blockInfo != null) {
Review Comment:
When `add new chosen targets to already allocated block or retry`,
`blockInfo` is null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
