EnricoMi commented on code in PR #8306:
URL: https://github.com/apache/hadoop/pull/8306#discussion_r3079802977


##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java:
##########
@@ -1770,6 +1770,34 @@ private Constants() {
    */
   public static final boolean DIRECTORY_OPERATIONS_PURGE_UPLOADS_DEFAULT = 
false;
 
+  /**
+   * When true, recursive deletion of a non-empty directory uses a single 
delete
+   * request for the directory key (prefix) instead of listing and deleting 
contained
+   * objects first. Only enable this for S3-compatible endpoints that support
+   * deleting non-empty directories (path prefix) in one request (e.g. VAST).
+   * Value: {@value}.
+   */
+  public static final String DELETE_NON_EMPTY_DIRECTORY_ENABLED =
+      "fs.s3a.delete.non-empty-directory.enabled";
+
+  /**
+   * Custom delete header required by some S3-compatible stores to delete a
+   * non-empty directory key (prefix) in one request.
+   * Value: {@value}.
+   */
+  public static final String DELETE_NON_EMPTY_DIRECTORY_HEADER =
+      "x-amz-delete-contents";

Review Comment:
   I wouldn't put a proprietary (non AWS S3) header to the project.
   
   Attempt #8417 is more generic and might be reusable for other purposes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to