pan3793 commented on code in PR #8412: URL: https://github.com/apache/hadoop/pull/8412#discussion_r3084190877
########## .github/workflows/tmpl_build_and_test.yml: ########## @@ -0,0 +1,152 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +name: Build and Test + +on: + workflow_call: + inputs: + java: + required: false + type: string + default: 17 + branch: + required: false + type: string + description: Branch to run the build against + default: trunk + os: + required: false + type: string + description: Operating system to run the build on + default: ubuntu_24 + jobs: + required: false + type: string + description: >- + Jobs to run, and should be in JSON Array format. + Candidates: "build-only". + default: '[ "build-only" ]' + +concurrency: + group: >- + build-and-test + ${{ github.workflow }} + ${{ github.repository == 'apache/hadoop' && github.run_id || github.ref }} + ${{ inputs.java }} + ${{ inputs.branch }} + ${{ inputs.os }} + ${{ inputs.jobs }} + cancel-in-progress: true + +env: + MAVEN_ARGS: + --batch-mode + --no-transfer-progress + -Pyarn-ui + -Pnative + -Drequire.test.libhadoop + -Drequire.fuse + -Drequire.openssl + -Drequire.snappy + -Drequire.valgrind + -Dmaven.test.failure.ignore=false + +jobs: + precondition: + name: Preparation + runs-on: ubuntu-24.04 + outputs: + infra_image_url: ${{ steps.variables.outputs.infra_image_url }} + steps: + - name: Set up Outputs + id: variables + run: | + echo "infra_image_url=ghcr.io/${{ github.repository }}/gha-${{ inputs.os }}:${{ inputs.branch }}-${{ github.run_id }}" >> $GITHUB_OUTPUT Review Comment: for PR, this workflow runs on the forked repo, the contributor already has full access to their forked repo, what does the benefit of doing shell injection? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
