[
https://issues.apache.org/jira/browse/HADOOP-19758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18075223#comment-18075223
]
ASF GitHub Bot commented on HADOOP-19758:
-----------------------------------------
deepujain commented on PR #8387:
URL: https://github.com/apache/hadoop/pull/8387#issuecomment-4290769810
Rebased this onto current apache/trunk and force-pushed the refreshed
branch. Local validation for the narrow shell change passed by sourcing
hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh,
simulating a PATH without tput, and verifying hadoop_generic_columnprinter
still prints the expected archive-logs usage text without a tput error message.
I also confirmed the branch still contains the matching bats regression in
hadoop_subcommands.bats.
> Hadoop shell scripts rely on ncurses in some distros
> ----------------------------------------------------
>
> Key: HADOOP-19758
> URL: https://issues.apache.org/jira/browse/HADOOP-19758
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Edward Capriolo
> Priority: Major
> Labels: pull-request-available
>
>
> {code:java}
> Client Commands:
> /opt/hadoop/bin/../libexec/hadoop-functions.sh: line 379: tput: command not
> found
> archive-logs combine aggregated logs into hadoop archives {code}
> From
> {code:java}
> else
> numcols=$(tput cols) 2>/dev/null
> - /opt/hadoop/bin/../libexec/hadoop-functions.sh [Readonly] 379/2774 13%
> {code}
> In
> [Alpine Linux|https://www.alpinelinux.org/], the {{tput}} command is part of
> the *{{ncurses}}* package and is not installed by default. The {{tput}}
> utility is used by shell scripts to control terminal features like colors and
> text positioning in a portable way
> Possibly consider removing this from shell scripts.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
