[
https://issues.apache.org/jira/browse/HADOOP-19858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18075285#comment-18075285
]
ASF GitHub Bot commented on HADOOP-19858:
-----------------------------------------
ajfabbri commented on PR #8412:
URL: https://github.com/apache/hadoop/pull/8412#issuecomment-4292354446
Ok I'm ready to approve this. Do you think it is ready?
I updated my [comment
above](https://github.com/apache/hadoop/pull/8412#issuecomment-4284241139) on
remaining tasks. I propose we:
- Fix the rebase (CI is complaining about it). I can do this for you if you
want, before merging.
- I will follow up on my question to INFRA
https://issues.apache.org/jira/browse/INFRA-27839. It shouldn't affect us now,
but I'd like to make sure we're protected if there are other
`pull_request_target` workflows added in the future.
- I will add my security review comments in a separate PR (I am eager to add
some stuff for S3A testing after this is merged!) (FWIW, [updated
here](https://github.com/ajfabbri/hadoop/pull/5/changes/4c8589289ca980bd9a7b1c2741d4655ba3a32161).
> Set up build workflow in GitHub Actions
> ---------------------------------------
>
> Key: HADOOP-19858
> URL: https://issues.apache.org/jira/browse/HADOOP-19858
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build
> Reporter: Cheng Pan
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
