Hean-Chhinling commented on PR #8449:
URL: https://github.com/apache/hadoop/pull/8449#issuecomment-4305722977
> Thanks Riya for the fix!
>
> what do you think can we modify the IncludeRootJsonProvider to handle
scenarios when DTO not present in any list?
>
> So kinda modify this
>
> ` boolean match =
classSerialisationConfig.getWrappedClasses().contains(type);`
>
> to
>
> ` boolean match =
classSerialisationConfig.getWrappedClasses().contains(type) ||
!classSerialisationConfig.getWrappedClasses().contains(type) &&
!classSerialisationConfig.getUnWrappedClasses().contains(type));`
That is a good idea.
May I ask why it should not be in the ExcludeRootJsonProvider?
The expected response format seems to be without the root element
Example:
```
{
"allowed": "true",
"user": "hive",
"diagnostics": ""
}
```
Not with root rmQueueAclInfo
```
{
"rmQueueAclInfo": {
"allowed": true,
"user": "yarn",
"diagnostics": ""
}
}
```
But please correct me if I am mistaken
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
