cnauroth commented on PR #8453: URL: https://github.com/apache/hadoop/pull/8453#issuecomment-4306289152
> only one I am worried about is HDFS and rolling upgrades. Does a change to keylength/algorithm for new shared secrets cause problems? This is the situation I had in mind. `SecretManager` wraps a `javax.crypto.Mac`, and it only knows how to create it with one specific algorithm. https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/SecretManager.java#L255 If we have some HmacSHA1 tokens in flight, and then we restart NameNode with the new configuration, will it start trying to verify the old tokens as HmacSHA1 and hit password mismatches here? https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java#L660-L663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
