pan3793 commented on code in PR #8451: URL: https://github.com/apache/hadoop/pull/8451#discussion_r3135111813
########## .github/workflows/build_image_cache.yml: ########## @@ -0,0 +1,53 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +name: Image Cache + +# Security: write privileges are safe since this is triggered only by +# `push` and `workflow_dispatch` (implying user has write access). +on: + # Run jobs when a commit is merged + push: + branches: + - 'trunk' + - 'branch-*' + paths: + - 'dev-support/docker/**' Review Comment: I think the cache is better. 1. in most cases, no docker file change, cache hit and it works well 2. if trunk merges a PR that has docker files change, it will take ~15min to refresh the cache, a new push happens in the forked PR will miss cache and do a refresh build 3. if a PR itself contains docker files change, it must do a fresh build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
