[
https://issues.apache.org/jira/browse/HADOOP-19859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18075854#comment-18075854
]
ASF GitHub Bot commented on HADOOP-19859:
-----------------------------------------
pan3793 commented on code in PR #8451:
URL: https://github.com/apache/hadoop/pull/8451#discussion_r3135111813
##########
.github/workflows/build_image_cache.yml:
##########
@@ -0,0 +1,53 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Image Cache
+
+# Security: write privileges are safe since this is triggered only by
+# `push` and `workflow_dispatch` (implying user has write access).
+on:
+ # Run jobs when a commit is merged
+ push:
+ branches:
+ - 'trunk'
+ - 'branch-*'
+ paths:
+ - 'dev-support/docker/**'
Review Comment:
I think the cache is better.
1. in most cases, no docker file change, cache hit and it works well
2. if trunk merges a PR that has docker files change, it will take ~15min to
refresh the cache, a new push happens in the forked PR will miss cache and do a
refresh build
3. if a PR itself contains docker files change, it must do a fresh build
> Use cache to speed up GHA infra image building
> ----------------------------------------------
>
> Key: HADOOP-19859
> URL: https://issues.apache.org/jira/browse/HADOOP-19859
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Cheng Pan
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
