pan3793 opened a new pull request, #8455:
URL: https://github.com/apache/hadoop/pull/8455
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
`MiniRPCBenchmark` still uses the legacy `WritableRPCEngine`-based
`MiniProtocol`, https://github.com/apache/hadoop/pull/8433 causes
`org.apache.hadoop.ipc.TestMiniRPCBenchmark` to fail.
This PR migrates it to `ProtobufRpcEngine2` to recover the
`TestMiniRPCBenchmark`
Contains content generated by Claude Opus 4.7
### How was this patch tested?
```
$ ./mvnw test -Dtest=TestMiniRPCBenchmark -pl
hadoop-common-project/hadoop-common
```
trunk
```
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.ipc.TestMiniRPCBenchmark
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
0.205 s <<< FAILURE! -- in org.apache.hadoop.ipc.TestMiniRPCBenchmark
[ERROR] org.apache.hadoop.ipc.TestMiniRPCBenchmark.testSimple -- Time
elapsed: 0.193 s <<< ERROR!
java.lang.IllegalStateException: No RPC engine configured for
org.apache.hadoop.ipc.MiniRPCBenchmark$MiniProtocol
at
org.apache.hadoop.util.Preconditions.checkState(Preconditions.java:298)
at org.apache.hadoop.ipc.RPC.getProtocolEngine(RPC.java:227)
at org.apache.hadoop.ipc.RPC$Builder.build(RPC.java:989)
at
org.apache.hadoop.ipc.MiniRPCBenchmark$MiniServer.<init>(MiniRPCBenchmark.java:170)
at
org.apache.hadoop.ipc.MiniRPCBenchmark.runMiniBenchmark(MiniRPCBenchmark.java:286)
at
org.apache.hadoop.ipc.TestMiniRPCBenchmark.testSimple(TestMiniRPCBenchmark.java:33)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
[INFO]
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR] TestMiniRPCBenchmark.testSimple:33 ยป IllegalState No RPC engine
configured for org.apache.hadoop.ipc.MiniRPCBenchmark$MiniProtocol
[INFO]
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0
```
this PR
```
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.ipc.TestMiniRPCBenchmark
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.315
s -- in org.apache.hadoop.ipc.TestMiniRPCBenchmark
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
```
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(HADOOP-19864)?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
### AI Tooling
If an AI tool was used:
- [x] The PR includes the phrase "Contains content generated by <tool>"
where <tool> is the name of the AI tool used.
- [x] My use of AI contributions follows the ASF legal policy
https://www.apache.org/legal/generative-tooling.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
