[
https://issues.apache.org/jira/browse/HADOOP-19864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18075867#comment-18075867
]
ASF GitHub Bot commented on HADOOP-19864:
-----------------------------------------
pan3793 opened a new pull request, #8455:
URL: https://github.com/apache/hadoop/pull/8455
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
`MiniRPCBenchmark` still uses the legacy `WritableRPCEngine`-based
`MiniProtocol`, https://github.com/apache/hadoop/pull/8433 causes
`org.apache.hadoop.ipc.TestMiniRPCBenchmark` to fail.
This PR migrates it to `ProtobufRpcEngine2` to recover the
`TestMiniRPCBenchmark`
Contains content generated by Claude Opus 4.7
### How was this patch tested?
```
$ ./mvnw test -Dtest=TestMiniRPCBenchmark -pl
hadoop-common-project/hadoop-common
```
trunk
```
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.ipc.TestMiniRPCBenchmark
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
0.205 s <<< FAILURE!
> Cut WritableRPCEngine
> ---------------------
>
> Key: HADOOP-19864
> URL: https://issues.apache.org/jira/browse/HADOOP-19864
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 3.6.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0
>
>
> Cut {{WritableRpcEngine}} from the code
> It's been obsolete for over a decade, with MAPREDUCE-6706 not needed
> internally.
> Tez still uses it (TEZ-4708 ) so this removal will be incompatible for them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
