ajfabbri commented on code in PR #8452: URL: https://github.com/apache/hadoop/pull/8452#discussion_r3164166851
########## .github/gha-tests/exclude-tests.txt: ########## @@ -0,0 +1,206 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# hadoop-common +**/org/apache/hadoop/ipc/TestRPC.java Review Comment: Which of these are just slow, and which tests are flaky / failures? Would be good to leave comments here and separate into sections, e.g. ``` # hadoop-hdfs ... # slow ... # flaky ``` for each project. ########## hadoop-common-project/hadoop-common/src/test/scripts/start-build-env.bats: ########## @@ -69,6 +69,7 @@ export -f stat # Verify that host directories get mounted without z option # and INFO messages get printed out @test "start-build-env.sh (Docker without z mount option)" { + skip "Skip on GitHub Actions now" Review Comment: ditto. ########## hadoop-common-project/hadoop-common/src/test/scripts/hadoop_stop_daemon.bats: ########## @@ -31,6 +31,7 @@ load hadoop-functions_test_helper } @test "hadoop_stop_daemon_force_kill" { + skip "Skip on GitHub Actions now" Review Comment: Why are we disabling this? Does this affect Yetus C? We could do a conditional skip based on an environment variable which is only set for GH actions. ########## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/oncrpc/TestFrameDecoder.java: ########## @@ -22,6 +22,8 @@ import static org.junit.jupiter.api.Assertions.assertFalse; Review Comment: This needs to be a separate commit. When you are ready to merge, we can do an interactive rebase to squash all commits except this one, and add a descriptive log message to this commit. ########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/pom.xml: ########## @@ -540,16 +540,6 @@ </execution> </executions> </plugin> - <!-- The fork value is deliberately set to 0 to avoid VM crash while running tests - on Jenkins, removing this leads to tests crashing silently due to VM crash --> - <!-- TODO: we should investigate and address the crash issue and re-enable fork, - otherwise, JPMS args does not take effect --> - <plugin> - <artifactId>maven-surefire-plugin</artifactId> - <configuration> - <forkCount>0</forkCount> - </configuration> - </plugin> Review Comment: Interesting. I agree we should fix the underlying issue. How can we make sure we catch "silent VM crashes" on jenkins? ########## hadoop-common-project/hadoop-common/src/test/scripts/start-build-env.bats: ########## @@ -89,6 +90,7 @@ export -f stat # Verify that host directories get mounted with z option @test "start-build-env.sh (Docker with z mount option)" { + skip "Skip on GitHub Actions now" Review Comment: and here ########## .github/workflows/tmpl_build_and_test.yml: ########## @@ -155,3 +156,139 @@ jobs: - name: Build shell: bash run: ./mvnw $MAVEN_ARGS clean install -DskipTests + build-and-test: + if: (!cancelled()) && contains(fromJSON(inputs.jobs), 'build-and-test') + name: Test ${{ matrix.comment }} (Java ${{ inputs.java }}) ${{ inputs.os }}-${{ inputs.branch }} + runs-on: ubuntu-24.04 + needs: [ precondition, build-image ] + container: + image: ${{ needs.precondition.outputs.build_image_url }} + options: --user ${{ needs.build-image.outputs.uid }} + strategy: + fail-fast: false + max-parallel: 6 + matrix: + include: + - comment: hdfs + modules: + -pl :hadoop-hdfs Review Comment: This seems fine. We have some work to do on improving tests: We need to make them faster, and completely eliminate flaky tests (ideally). This gives us an iterative way to tackle it. 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
