[
https://issues.apache.org/jira/browse/HADOOP-19876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18077423#comment-18077423
]
ASF GitHub Bot commented on HADOOP-19876:
-----------------------------------------
dombizita opened a new pull request, #8465:
URL: https://github.com/apache/hadoop/pull/8465
### Description of PR
In `HttpServer2.setEnabledProtocols()`, the logic that applies SSL protocol
restrictions to the Jetty SslContextFactory is gated behind a check that
compares the resolved configuration value against
`SSLFactory.SSL_ENABLED_PROTOCOLS_DEFAULT` ("TLSv1.2"). This means that Jetty
is not respecting the configuration, the condition check should be removed.
### How was this patch tested?
Tested the changes manually with `openssl s_client -connect` commands.
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
### AI Tooling
No AI tool was used.
If an AI tool was used:
- [ ] The PR includes the phrase "Contains content generated by <tool>"
where <tool> is the name of the AI tool used.
- [ ] My use of AI contributions follows the ASF legal policy
https://www.apache.org/legal/generative-tooling.html
> SSL protocol config is not applied to Jetty when set to default value
> ---------------------------------------------------------------------
>
> Key: HADOOP-19876
> URL: https://issues.apache.org/jira/browse/HADOOP-19876
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Zita Dombi
> Assignee: Zita Dombi
> Priority: Major
>
> In HttpServer2.setEnabledProtocols(), the logic that applies SSL protocol
> restrictions to the Jetty SslContextFactory is gated behind a check that
> compares the resolved configuration value against
> SSLFactory.SSL_ENABLED_PROTOCOLS_DEFAULT ("TLSv1.2").
> [https://github.com/apache/hadoop/blob/b322c3ce2c10b45cec2f9acbe6f00fb75c054caa/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java#L709]
>
> This means that Jetty is not respecting the configuration, the condition
> check should be removed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
