ajfabbri commented on code in PR #8303:
URL: https://github.com/apache/hadoop/pull/8303#discussion_r3184397078
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AFileSystemIsolatedClassloader.java:
##########
@@ -205,4 +205,29 @@ public void notIsolatedClassloader() throws IOException {
.isInstanceOf(CustomCredentialsProvider.class);
});
}
+
+ /**
+ * HADOOP-19833: When isolation=false, getInstanceFromReflection must use
+ * the context classloader (or conf's classloader) so that classes from the
+ * application classpath can be loaded. This test calls
getInstanceFromReflection
+ * directly with isolation=false and verifies the custom class is
instantiated.
+ */
+ @Test
+ public void testGetInstanceFromReflectionWithIsolationFalse() throws
Exception {
Review Comment:
This PR currently only adds a test--it doesn't include any production logic
changes. Please clarify if this is supposed to be a bug fix or not, and update
the description of the PR and JIRA accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
