[
https://issues.apache.org/jira/browse/HADOOP-8569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409071#comment-13409071
]
Colin Patrick McCabe commented on HADOOP-8569:
----------------------------------------------
What I'm afraid of is issues where some function or feature is not detected as
present because _GNU_SOURCE was not defined. Unfortunately, when you
artificially hide functions, these kind of issues are all too common, and they
can prove difficult to diagnose.
There's really no disadvantage to defining _GNU_SOURCE that I'm aware of, so
most projects just define it everywhere. I think we should too.
> CMakeLists.txt: define _GNU_SOURCE and _LARGEFILE_SOURCE
> --------------------------------------------------------
>
> Key: HADOOP-8569
> URL: https://issues.apache.org/jira/browse/HADOOP-8569
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8569.001.patch
>
>
> In the native code, we should define _GNU_SOURCE and _LARGEFILE_SOURCE so
> that all of the functions on Linux are available.
> _LARGEFILE enables fseeko and ftello; _GNU_SOURCE enables a variety of
> Linux-specific functions from glibc, including sync_file_range.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
