steveloughran commented on code in PR #8506:
URL: https://github.com/apache/hadoop/pull/8506#discussion_r3303153722
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/api/records/TestResource.java:
##########
@@ -43,6 +43,11 @@ void testCastToIntSafely() {
Resource.castToIntSafely(Long.MAX_VALUE),
"Cast to Integer.MAX_VALUE if the long is greater than "
+ "Integer.MAX_VALUE");
+
+ assertEquals(0, Resource.castToIntSafely(-1),
Review Comment:
keeping with assertEquals as it's already in use...FYI for new test suites
we like AssertJ as it's more informative and cherrypicks easily from junit5
branches (3.5+) and Junit4 (3.4.x)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
