[
https://issues.apache.org/jira/browse/HADOOP-19905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18083772#comment-18083772
]
ASF GitHub Bot commented on HADOOP-19905:
-----------------------------------------
magnuma3 opened a new pull request, #8520:
URL: https://github.com/apache/hadoop/pull/8520
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
HADOOP-19905
HttpServer2Metrics (HADOOP-17133) exposes only StatisticsHandler
counters. It says nothing about the Jetty thread pool, so
administrators have no metric-level visibility into thread pool
saturation.
This patch adds gauges to HttpServer2Metrics:
* Pool: maxThreads, minThreads, threads, idleThreads, busyThreads, queueSize
* Per role (summed over connectors): acceptorThreads, selectorThreads
* Worker only (pool count minus acceptors and selectors):
maxWorkerThreads, workerThreads, busyWorkerThreads
The worker-only gauges are exposed separately because acceptor and
selector threads sit in blocking accept()/select() loops and never go
idle
### How was this patch tested?
unit test and it has been running in production for over a year.
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
### AI Tooling
If an AI tool was used:
- [ ] The PR includes the phrase "Contains content generated by <tool>"
where <tool> is the name of the AI tool used.
- [ ] My use of AI contributions follows the ASF legal policy
https://www.apache.org/legal/generative-tooling.html
> Implement HttpServer2 thread pool metrics
> -----------------------------------------
>
> Key: HADOOP-19905
> URL: https://issues.apache.org/jira/browse/HADOOP-19905
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: KWON BYUNGCHANG
> Priority: Major
>
> HttpServer2Metrics (HADOOP-17133) exposes only StatisticsHandler
> counters. It says nothing about the Jetty thread pool, so
> administrators have no metric-level visibility into thread pool
> saturation.
>
> This patch adds gauges to HttpServer2Metrics:
>
> * Pool: maxThreads, minThreads, threads, idleThreads, busyThreads, queueSize
> * Per role (summed over connectors): acceptorThreads, selectorThreads
> * Worker only (pool count minus acceptors and selectors):
> maxWorkerThreads, workerThreads, busyWorkerThreads
>
> The worker-only gauges are exposed separately because acceptor and
> selector threads sit in blocking accept()/select() loops and never go
> idle;
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
