cxzl25 commented on code in PR #8553:
URL: https://github.com/apache/hadoop/pull/8553#discussion_r3541223343
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:
##########
@@ -2524,6 +2525,10 @@ private void checkDataLength(int dataLength) throws
IOException {
maxDataLength + ". RPC came from " + getHostAddress();
LOG.warn(error);
throw new IOException(error);
+ } else if (warnDataLength > 0 && dataLength > warnDataLength) {
+ LOG.warn(
Review Comment:
1. Different purpose: the max length is a hard limit (reject), the warn
threshold is just a heads-up (notice).
2. Different clusters, different norms: what's "too big" varies by workload.
A fixed ratio can't fit everyone — a separate config can.
3. Need an off switch: operators may want to silence the warning without
touching the hard limit. -1 gives a clean way to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
