smengcl opened a new pull request, #8592: URL: https://github.com/apache/hadoop/pull/8592
### Description of PR Prompted by [HADOOP-16943](https://issues.apache.org/jira/browse/HADOOP-16943), I noticed that Windows hadoop-config.cmd still disables IPv6. On Unix the IPv4 pin has been overridable since [HADOOP-9902](https://issues.apache.org/jira/browse/HADOOP-9902): hadoop-functions.sh uses `${HADOOP_OPTS:-"-Djava.net.preferIPv4Stack=true"}`, so setting HADOOP_OPTS selects dual-stack or IPv6. hadoop-config.cmd never matched it. It appended the pin unconditionally, so IPv6 could not be enabled on Windows at all. Apply the pin only when HADOOP_OPTS is unset, mirroring the Unix default. IPv4 stays the default when HADOOP_OPTS is unset; operators who set it can now choose dual-stack or IPv6. ### How was this patch tested? n/a. There's no Windows CI. ### For code changes: - [x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files? ### AI Tooling If an AI tool was used: - [ ] The PR includes the phrase "Contains content generated by <tool>" where <tool> is the name of the AI tool used. - [ ] My use of AI contributions follows the ASF legal policy https://www.apache.org/legal/generative-tooling.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
