singer-bin commented on PR #8595: URL: https://github.com/apache/hadoop/pull/8595#issuecomment-4930474992
Hi @pan3793 , thanks for flagging this — I've looked into it and opened an addendum PR: #8595. **Root cause:** `DistributedShellBaseTest#setupInternal` enables `NM_PMEM_CHECK_ENABLED` / `NM_VMEM_CHECK_ENABLED` (the comment there is just "Enable ContainersMonitorImpl"). Before YARN-11967, those checks were **silent no-ops**, because `strictMemoryEnforcement` defaulted to `true` and `checkLimit()` early-returned before the polling logic. After YARN-11967, `strictMemoryEnforcement` defaults to `false` (it now also requires `yarn.nodemanager.resource.memory.enabled`, which is `false` by default), so the polling check actually runs and kills the MiniYARNCluster containers that legitimately exceed the tiny `MIN_ALLOCATION_MB` limit. **Fix (in #8595):** disable the polling pmem/vmem checks in the base test config. `ContainersMonitorImpl` itself is still enabled (`NM_CONTAINER_MONITOR_ENABLED` defaults to `true` and does not depend on the check flags), so utilization tracking used by the opportunistic-container setup right below is preserved. The DistributedShell tests never asserted on memory-kill behaviour, so no coverage is lost. Would appreciate your review on #8595. Thanks again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
