ferdelyi opened a new pull request, #8606:
URL: https://github.com/apache/hadoop/pull/8606
OpenClover (the open-sourced fork of Atlassian Clover) is incompatible with
Java 17+ because it relies on source-level instrumentation via a javac
annotation processor that triggers split-package violations in the module
system. JaCoCo uses bytecode instrumentation via a Java agent and has no such
constraint.
Changes:
- pom.xml: remove com.cenqua.clover dependency management, replace
clover-maven-plugin in pluginManagement with jacoco-maven-plugin 0.8.15, add
hadoop-coverage aggregate module, drop the <profile id="clover"> block entirely
- hadoop-project/pom.xml: add hadoop.skip-jacoco=true property (opt-in by
default), append @{argLine} to the surefire argLine so the JaCoCo agent is
injected into every forked test JVM, add jacoco-agent.destfile system property,
wire in jacoco:prepare-agent execution
- hadoop-coverage/pom.xml (new): aggregate module that depends on all source
modules and runs jacoco:report-aggregate at verify phase to produce a combined
HTML/XML report under hadoop-coverage/target/site/jacoco-aggregate/
- hadoop-maven-plugins/pom.xml, hadoop-yarn-server-nodemanager/pom.xml:
remove stale clover skip overrides that are no longer needed
To generate coverage:
mvn test -Dhadoop.skip-jacoco=false -Dmaven.test.failure.ignore=true mvn
verify -pl hadoop-coverage -Dhadoop.skip-jacoco=false
Generated-by: Claude Code
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
### How was this patch tested?
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
### AI Tooling
If an AI tool was used:
- [x] The PR includes the phrase "Contains content generated by <tool>"
where <tool> is the name of the AI tool used.
- [x] My use of AI contributions follows the ASF legal policy
https://www.apache.org/legal/generative-tooling.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
