konstantinb commented on PR #8427: URL: https://github.com/apache/hadoop/pull/8427#issuecomment-4995686097
Gentle ping for review — this has been open since April and is a small, self-contained change. It extends the existing ignorable-error handling already present in `exceptionCaught` (`ClosedChannelException` / `IGNORABLE_ERROR_MESSAGE`) into the `operationComplete` path, so routine client disconnects during `sendMap` log at DEBUG instead of ERROR. No functional or API change: the channel is still closed and the future short-circuits exactly as before — the only change is logging, where client-disconnect causes now take a dedicated DEBUG message instead of the ERROR line, matching the handling already in `exceptionCaught`. Includes a parameterized test covering both the ignorable cases and the genuine-error case. Merged in recent trunk changes yesterday, and Yetus is green. @pjfanning would you have a few minutes to take a look, given your recent Netty work in this area? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
