pjfanning commented on PR #8654: URL: https://github.com/apache/hadoop/pull/8654#issuecomment-5251965837
> @pjfanning thanks for your effort, I go through the non-test code and `pom.xml` changes, almost LGTM, but I think we should not add `com.fasterxml.jackson.annotation.*` to Hadoop public API, and I believe it can be replaced with a caller-side static method or something else that easy to implement. jackson-annotations is a non-optional dependency of jackson-databind - a heavily used lib in Hadoop https://mvnrepository.com/artifact/com.fasterxml.jackson.core/jackson-databind/2.18.9/dependencies Jackson-Databind is heavily dependent on annotations generally. jetty-util-ajax serializes using toString results of classes while Jackson's default behaviour is to write the class state as a JSON object. `@JsonValue` is by far the most effective way to get Jackson-Databind to retain the existing behaviour inherited from jetty-util-ajax. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
