joseluisll commented on PR #8682: URL: https://github.com/apache/hadoop/pull/8682#issuecomment-5281664150
Cross-reference: this pairs with #8659 (HDFS-17957), which sets a default `junit.jupiter.execution.timeout.default` on the hdfs modules. The two cover different halves of the same problem. This PR restores the thread dump for tests that fail *through JUnit*, and explicitly cannot cover a fork killed at `forkedProcessTimeoutInSeconds`: Surefire sends the fork `Shutdown.KILL`, the fork executes `Runtime.halt()`, and that bypasses listeners and shutdown hooks alike. #8659 is what moves hung hdfs tests off that path — with a default `@Timeout` they fail through JUnit instead, at which point this listener produces the dump. Neither PR alone yields a usable diagnostic for a hung HDFS test. The two touch one file in common, `hadoop-hdfs-project/hadoop-hdfs/pom.xml`: #8659 adds inside `<systemPropertyVariables>`, this one removes the dead `<properties>` listener block just after it. I trial-merged the two heads and the result is clean, with both changes intact, in either order — no rebase needed whichever lands first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
