anmolanmol1234 commented on code in PR #8611: URL: https://github.com/apache/hadoop/pull/8611#discussion_r3842810464
########## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/contract/TestResponseParserFactory.java: ########## @@ -0,0 +1,121 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.fs.azurebfs.contract; + +import java.util.function.Supplier; + +import javax.xml.parsers.SAXParser; +import javax.xml.parsers.SAXParserFactory; + +import org.junit.jupiter.api.Test; + +import org.apache.hadoop.fs.azurebfs.contracts.services.ArrowListBlobParser; +import org.apache.hadoop.fs.azurebfs.contracts.services.ListBlobResponseParser; +import org.apache.hadoop.fs.azurebfs.contracts.services.ResponseParserFactory; +import org.apache.hadoop.fs.azurebfs.contracts.services.XmlListBlobResponseParser; + +import static org.apache.hadoop.fs.azurebfs.constants.AbfsHttpConstants.APPLICATION_APACHE_ARROW_STREAM; +import static org.apache.hadoop.fs.azurebfs.constants.AbfsHttpConstants.APPLICATION_XML; +import static org.assertj.core.api.Assertions.assertThat; + +/** + * Unit tests for {@link ResponseParserFactory} parser selection based on the + * response Content-Type. + */ +public class TestResponseParserFactory { + + private static final String BASE_URL = + "https://account.blob.core.windows.net/container";; + + private static final long ARROW_MEMORY_LIMIT = 256L * 1024 * 1024; + + private static final Supplier<SAXParser> SAX_PARSER_SUPPLIER = () -> { + try { + return SAXParserFactory.newInstance().newSAXParser(); + } catch (Exception e) { + throw new RuntimeException(e); + } + }; + + @Test + public void testArrowContentTypeSelectsArrow() { + assertThat(ResponseParserFactory.isArrowResponse( + APPLICATION_APACHE_ARROW_STREAM)).isTrue(); + } + + @Test + public void testArrowContentTypeWithCharsetSelectsArrow() { + assertThat(ResponseParserFactory.isArrowResponse( + "application/vnd.apache.arrow.stream; charset=utf-8")).isTrue(); + } + + @Test + public void testArrowContentTypeIsCaseInsensitive() { + assertThat(ResponseParserFactory.isArrowResponse( + "APPLICATION/VND.APACHE.ARROW.STREAM")).isTrue(); + } + + @Test + public void testXmlContentTypeDoesNotSelectArrow() { + assertThat(ResponseParserFactory.isArrowResponse(APPLICATION_XML)).isFalse(); + } + + @Test + public void testUnrelatedContentTypeContainingArrowDoesNotSelectArrow() { + // Content types that merely contain the word "arrow" (e.g. a different Review Comment: The ResponseParserFactory javadoc says "any structured-suffix or parameter portion is tolerated", but the code only handles parameters — a structured suffix like application/vnd.apache.arrow.stream+ipc is rejected. Either drop that line from the javadoc or add a test pinning the intended behaviour; right now the doc and the code disagree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
