pan3793 commented on code in PR #8707: URL: https://github.com/apache/hadoop/pull/8707#discussion_r3903769923
########## pom.xml: ########## @@ -866,6 +885,27 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/x <outputFormat>xml</outputFormat> </configuration> </plugin> + <plugin> + <!-- Post-processes the CycloneDX SBOM into a 1.7 document that + marks dependencies shaded into the jar by maven-shade-plugin. + See dev-support/sbom/sbom.groovy. --> + <groupId>org.codehaus.gmavenplus</groupId> + <artifactId>gmavenplus-plugin</artifactId> + <executions> + <execution> + <id>sbom-postprocess</id> + <phase>verify</phase> + <goals> + <goal>execute</goal> + </goals> + <configuration> + <scripts> + <script>${maven.multiModuleProjectDirectory}/dev-support/sbom/sbom.groovy</script> Review Comment: I don't understand why things do not happen in CycloneDX/cyclonedx-maven-plugin if it matters (I read the issue link, but it's unclear what the exact blocker is that makes it can NOT happen in upstream. I do have concerns about introducing a new language to work around such an issue. If some committers think we MUST do it, please write it in full Java syntax (suppose Groovy syntax is a real superset of Java) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
