[
https://issues.apache.org/jira/browse/HADOOP-19979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18111765#comment-18111765
]
ASF GitHub Bot commented on HADOOP-19979:
-----------------------------------------
joseluisll opened a new pull request, #8717:
URL: https://github.com/apache/hadoop/pull/8717
### Description of PR
https://issues.apache.org/jira/browse/HADOOP-19979
Two tests assert on work that finishes on another thread, without
waiting for it. Both fail intermittently.
`TestSSLHttpServerMTLS.testUntrustedClientIsRejected` expects an
`SSLHandshakeException`. The server drops the connection as soon as it
rejects the client certificate, racing the client's last handshake
flight; when the close wins, the client fails writing it and gets a
`SocketException` instead. 7 of 25 runs fail. The server guarantees the
request is refused, not which exception the client sees, so assert that.
`TestLogAggregationService.testLocalFileDeletionAfterUpload` waits for
each log file to disappear, then asserts on the enclosing directory with
no wait. `DeletionService` removes files before the directories holding
them, so the assertion can run in between. Hit 4 of the 60 most recent
PRs, including unrelated ones. Wait for the directory too.
### How was this patch tested?
JDK 17, Ubuntu 24.04.
`TestSSLHttpServerMTLS` run 25 times: 18 passed before the change, 25
after. `TestSSLHttpServer`, `TestSSLHttpServerConfigs` and
`TestSSLFactory` pass alongside it, 40 tests.
`TestLogAggregationService` passes as a class, 49 tests.
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
> Fix flaky TestLogAggregationService and TestSSLHttpServerMTLS
> -------------------------------------------------------------
>
> Key: HADOOP-19979
> URL: https://issues.apache.org/jira/browse/HADOOP-19979
> Project: Hadoop Common
> Issue Type: Test
> Components: common, test
> Reporter: Jose Luis López
> Priority: Minor
>
> Two tests assert on work that finishes on another thread, without
> waiting for it. Both fail intermittently.
> TestSSLHttpServerMTLS.testUntrustedClientIsRejected expects an
> SSLHandshakeException. The server drops the connection as soon as it
> rejects the client certificate, racing the client's last handshake
> flight; when the close wins, the client fails writing it and gets a
> SocketException instead. 7 of 25 runs fail. The server guarantees the
> request is refused, not which exception the client sees, so assert
> that.
> TestLogAggregationService.testLocalFileDeletionAfterUpload waits for
> each log file to disappear, then asserts on the enclosing directory
> with no wait. DeletionService removes files before the directories
> holding them, so the assertion can run in between. Hit 4 of the 60 most
> recent PRs, including unrelated ones. Wait for the directory too.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
