[
https://issues.apache.org/jira/browse/HADOOP-19978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18111800#comment-18111800
]
ASF GitHub Bot commented on HADOOP-19978:
-----------------------------------------
hadoop-yetus commented on PR #8720:
URL: https://github.com/apache/hadoop/pull/8720#issuecomment-5549728858
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 49s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available.
|
| +0 :ok: | xmllint | 0m 1s | | xmllint was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
|||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 2m 37s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 45m 48s | | trunk passed |
| +1 :green_heart: | compile | 17m 50s | | trunk passed with JDK
Ubuntu-21.0.12+8-1-24.04-Ubuntu |
| +1 :green_heart: | compile | 17m 49s | | trunk passed with JDK
Ubuntu-17.0.20+8-1-24.04-Ubuntu |
| +1 :green_heart: | mvnsite | 3m 36s | | trunk passed |
| +1 :green_heart: | javadoc | 3m 20s | | trunk passed with JDK
Ubuntu-21.0.12+8-1-24.04-Ubuntu |
| +1 :green_heart: | javadoc | 3m 12s | | trunk passed with JDK
Ubuntu-17.0.20+8-1-24.04-Ubuntu |
| +1 :green_heart: | shadedclient | 125m 38s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 29s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 43s | | the patch passed |
| +1 :green_heart: | compile | 17m 0s | | the patch passed with JDK
Ubuntu-21.0.12+8-1-24.04-Ubuntu |
| +1 :green_heart: | javac | 17m 0s | | the patch passed |
| +1 :green_heart: | compile | 17m 59s | | the patch passed with JDK
Ubuntu-17.0.20+8-1-24.04-Ubuntu |
| +1 :green_heart: | javac | 17m 59s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | mvnsite | 3m 32s | | the patch passed |
| +1 :green_heart: | javadoc | 3m 3s | | the patch passed with JDK
Ubuntu-21.0.12+8-1-24.04-Ubuntu |
| +1 :green_heart: | javadoc | 3m 9s | | the patch passed with JDK
Ubuntu-17.0.20+8-1-24.04-Ubuntu |
| +1 :green_heart: | shadedclient | 43m 14s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 44s | | hadoop-project in the patch
passed. |
| +1 :green_heart: | unit | 1m 42s | | hadoop-registry in the patch
passed. |
| -1 :x: | unit | 23m 6s |
[/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-services_hadoop-yarn-services-core.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8720/2/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-services_hadoop-yarn-services-core.txt)
| hadoop-yarn-services-core in the patch passed. |
| -1 :x: | unit | 1m 39s |
[/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-applications-catalog_hadoop-yarn-applications-catalog-webapp.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8720/2/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-applications-catalog_hadoop-yarn-applications-catalog-webapp.txt)
| hadoop-yarn-applications-catalog-webapp in the patch failed. |
| +1 :green_heart: | asflicense | 1m 15s | | The patch does not
generate ASF License warnings. |
| | | 237m 40s | | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.yarn.service.TestYarnNativeServices |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.56 ServerAPI=1.56 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8720/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/8720 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient codespell detsecrets xmllint |
| uname | Linux efa920b301df 5.15.0-190-generic #200-Ubuntu SMP Fri Aug 7
15:06:04 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / c86ba553f537fa5935ebbaa4e958f210ad232b45 |
| Default Java | Ubuntu-17.0.20+8-1-24.04-Ubuntu |
| Multi-JDK versions |
/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.12+8-1-24.04-Ubuntu
/usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.20+8-1-24.04-Ubuntu |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8720/2/testReport/ |
| Max. process+thread count | 891 (vs. ulimit of 10000) |
| modules | C: hadoop-project hadoop-common-project/hadoop-registry
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp
U: . |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8720/2/console |
| versions | git=2.43.0 maven=3.9.15 |
| Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
This message was automatically generated.
> Upgrade maven-surefire-plugin to 3.6
> ------------------------------------
>
> Key: HADOOP-19978
> URL: https://issues.apache.org/jira/browse/HADOOP-19978
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common, test
> Reporter: Jose Luis López
> Priority: Major
> Labels: pull-request-available
>
> *Why*
> HADOOP-19964 reimplements TimedOutTestsListener as a JUnit Platform
> TestExecutionListener, so a timed-out test prints a thread dump again. The
> listener property that eight poms already carry binds only once Surefire
> accepts platform listeners - SUREFIRE-1639, shipped in maven-surefire-plugin
> 3.6.0. On 3.5.3 the property is inert, so the listener stays dormant until
> Hadoop moves to that version.
> *What the upgrade needs*
> Bumping 3.5.3 to 3.6.0 on its own turns 5 of 7 CI test jobs red: common, mr,
> hdfs-rbf, hdfs-other, hdfs-slow. Controlled against another branch built the
> same morning on the same runners with 3.5.3, which was 7/7 green. Every
> failure is one fault - the forked JVM preferring IPv6, e.g.
> TestNameNodeRpcServer.testNamenodeRpcBindAny expected <0.0.0.0> but was
> <0:0:0:0:0:0:0:0>.
> hadoop-project.xml sets java.net.preferIPv4Stack in surefire's
> systemPropertyVariables. Those are applied by the forked booter once the JVM
> is already running, never as -D at startup. 3.6.0 initialises the fork's
> networking before applying them, so the flag is read too late; 3.5.3 applies
> them before any networking class loads, which is why the same configuration
> works there. No property-based fix can work.
> *Changes*
> # maven-surefire-plugin.version to 3.6.0.
> # Move -Djava.net.preferIPv4Stack=true into maven-surefire-plugin.argLine,
> where it is a real JVM startup argument. All 22 argLine overrides interpolate
> that property and maven-failsafe-plugin shares it, so it propagates
> everywhere. Drop hadoop-registry's duplicate copy of the same ineffective
> systemPropertyVariable.
> # Add hadoop-common's test-jar in test scope to hadoop-yarn-services-core and
> hadoop-yarn-applications-catalog-webapp. Both inherit the listener property
> from hadoop-yarn but resolve only hadoop-common's main jar, so Surefire
> cannot load the listener class and silently drops it.
> *Also in 3.6.0*
> SUREFIRE-823 decouples -DskipTests from maven-failsafe-plugin: -DskipTests no
> longer skips integration tests, only -DskipITs does.
> hadoop-client-integration-tests relies on -DskipTests alone, so its ITs now
> run under "mvn install -DskipTests". The cloud connectors gate on skipITs and
> are unaffected. To be fixed here or in a follow-up.
> The legacy surefire-junit3/junit4/junit47/testng providers are removed in
> 3.6.0. Hadoop has no JUnit 4 or TestNG tests, so this does not apply.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
