[
https://issues.apache.org/jira/browse/HADOOP-8531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414700#comment-13414700
]
Hadoop QA commented on HADOOP-8531:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12536561/HADOOP-8531-2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test
files.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests in
hadoop-common-project/hadoop-common:
org.apache.hadoop.ha.TestZKFailoverController
org.apache.hadoop.io.file.tfile.TestTFileByteArrays
org.apache.hadoop.io.file.tfile.TestTFileJClassComparatorByteArrays
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1197//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1197//console
This message is automatically generated.
> SequenceFile Writer can throw out a better error if a serializer isn't
> available
> --------------------------------------------------------------------------------
>
> Key: HADOOP-8531
> URL: https://issues.apache.org/jira/browse/HADOOP-8531
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Harsh J
> Assignee: madhukara phatak
> Priority: Trivial
> Labels: newbie
> Attachments: HADOOP-8531-1.patch, HADOOP-8531-2.patch,
> HADOOP-8531-2.patch, HADOOP-8531.patch
>
>
> Currently, if the provided Key/Value class lacks a proper serializer in the
> loaded config for the SequenceFile.Writer, we get an NPE as the null return
> goes unchecked.
> Hence we get:
> {code}
> java.lang.NullPointerException
> at org.apache.hadoop.io.SequenceFile$Writer.init(SequenceFile.java:1163)
> at
> org.apache.hadoop.io.SequenceFile$Writer.<init>(SequenceFile.java:1079)
> at
> org.apache.hadoop.io.SequenceFile$RecordCompressWriter.<init>(SequenceFile.java:1331)
> at org.apache.hadoop.io.SequenceFile.createWriter(SequenceFile.java:271)
> {code}
> We can provide a better message + exception in such cases. This is slightly
> related to MAPREDUCE-2584.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
